Present perfect or past simple. what (you/eat) today? i (not/play) tennis for a year. my grandfather (fight0 in the second world war . how long (you/know) them? not very long.
What have you eaten today? I have not played tennis for a year. My grandfather fought in the Second World War. How long have you known them? Not very long.